refactor: allow pasting Drip List URLs when setting streams #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for drips-app-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
efstajas
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #852
Also adds the ability to name streams to Drip Lists and fixes an issue that does not allow users to update a stream's name.
The only thing I am not really happy about is when you paste the Drip List URL while setting the stream receiver, it resolves directly to the Drip List ID. It might be a bit confusing but the card at the top of the modal showing the stream from => to clearly shows the resolved drip list name. Making it to resolve to something else by reusing what's already there and not introducing more changes, is not so easy, unless I am missing something. We can do it if needed, of course.